Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mautrix-whatsapp: 0.10.9 -> 0.11.0 #349492

Merged
merged 1 commit into from
Oct 19, 2024
Merged

mautrix-whatsapp: 0.10.9 -> 0.11.0 #349492

merged 1 commit into from
Oct 19, 2024

Conversation

chvp
Copy link
Member

@chvp chvp commented Oct 18, 2024 •
edited
Loading

https://github.com/mautrix/whatsapp/releases/tag/v0.11.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from Ma27 and Vskilet October 18, 2024 10:49
Ma27
Ma27 requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual upgrade worked well for me.

However, I think this is too disruptive to submit to 24.05. The release will be EOL soon anyways, so it may even work out.

I'd even go as far as putting it into the release notes. WDYT?

@chvp
Copy link
Member Author

chvp commented Oct 19, 2024

Sure, sounds good

@chvp chvp force-pushed the upd/mautrix-whatsapp branch from bdaa001 to cd34981 Compare October 19, 2024 09:16
@chvp chvp requested a review from Ma27 October 19, 2024 09:16
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Oct 19, 2024
@Ma27 Ma27 merged commit 617552d into NixOS:master Oct 19, 2024
33 of 34 checks passed
@wietsedv wietsedv mentioned this pull request Oct 22, 2024
Open
13 tasks
@niklaskorz
Copy link
Contributor

niklaskorz commented Nov 30, 2024 •
edited
Loading

Bit too late now, but I wish this update would have been in one PR with the module changes. I'll see if I can help out finishing the module changes next week, but until then mautrix-whatsapp is in a broken state for me on NixOS 24.11 (as a temporary fix, I've overlayed the old version from 24.05).

@Ma27
Copy link
Member

Ma27 commented Dec 1, 2024

Oof yeah you're right.
I think the core issue is that I'm using these modules since before these modules were introduced and I wasn't really aware we even have a mautrix-whatsapp module (or forgot about it). For signal I touched the module if necessary even though I don't use it.

Thank you for bringing this to my attention.
I'll make sure to update stuff on my own there and ping people using it if it's a non-trivial change.

@chvp chvp deleted the upd/mautrix-whatsapp branch December 2, 2024 08:12
@chvp
Copy link
Member Author

chvp commented Dec 2, 2024

I also didn't know the module existed 😞.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@Vskilet Vskilet Awaiting requested review from Vskilet

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chvp @niklaskorz @Ma27